Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #926 Update container to v4 #928

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Conversation

remyperona
Copy link
Contributor

Description

Fixes #926

Type of change

  • Enhancement (non-breaking change which improves an existing functionality).

Detailed scenario

No steps to reproduce, there should be no visible difference (except a possible small performance improvement)

Technical description

Documentation

Update the container to v4, with the following changes:

  • replace share() method by addShared()
  • implement new method provides()
  • update classes instantiation to use class name instead of alias and get() method

New dependencies

league/container: ^4.2

Mandatory Checklist

Code validation

  • I validated all the Acceptance Criteria. If possible, provide screenshots or videos.
  • I triggered all changed lines of code at least once without new errors/warnings/notices.

Code style

  • I wrote a self-explanatory code about what it does.
  • I protected entry points against unexpected inputs.
  • I did not introduce unnecessary complexity.

@remyperona remyperona self-assigned this Nov 21, 2024
@remyperona remyperona requested a review from a team November 21, 2024 17:06
@remyperona remyperona added this pull request to the merge queue Nov 27, 2024
Merged via the queue into develop with commit 6f204e3 Nov 27, 2024
7 of 8 checks passed
@remyperona remyperona deleted the chore/update-container branch November 27, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade container to v4
2 participants